-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: remove default search time range of cluster_log when query without time range. (#16938) #17003
Merged
sre-bot
merged 2 commits into
pingcap:release-4.0
from
sre-bot:release-4.0-1c3435b4a621
May 14, 2020
Merged
executor: remove default search time range of cluster_log when query without time range. (#16938) #17003
sre-bot
merged 2 commits into
pingcap:release-4.0
from
sre-bot:release-4.0-1c3435b4a621
May 14, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…without time range. (pingcap#16938)
/run-all-tests |
ghost
requested a review
from wshwsh12
May 7, 2020 02:46
ghost
requested a review
from francis0407
May 7, 2020 02:46
/rebuild |
zz-jason
reviewed
May 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Deardrops
approved these changes
May 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
wshwsh12
added
status/LGT2
Indicates that a PR has LGTM 2.
and removed
status/LGT1
Indicates that a PR has LGTM 1.
labels
May 13, 2020
zz-jason
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
May 14, 2020
Your auto merge job has been accepted, waiting for:
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
sig/execution
SIG execution
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
type/4.0-cherry-pick
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #16938 to release-4.0
What problem does this PR solve?
Before this PR, when query the
cluster_log
table, if the user doesn't specify the time range, the default behavior is searching the recent 30 minutes logs, But DBA think this is not right, maybe return an error when the user querycluster_log
doesn't specify the time range, just as below:How it Works:
Related changes
Check List
Tests
Side effects
Release note