Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: fix wrong plan type for dataReaderBuilder... (#17028) #17036

Merged
merged 1 commit into from
May 9, 2020
Merged

executor: fix wrong plan type for dataReaderBuilder... (#17028) #17036

merged 1 commit into from
May 9, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented May 8, 2020

cherry-pick #17028 to release-4.0

What problem does this PR solve?

Issue Number: close #16973

Problem Summary:
After PR #16389 TiDB will push down all the expr supported by TiKV or TiFlash in predicate push down stage, so if there is an expr which only supported by TiFlash, a physical selection will be added after index read, but current implementation of buildExecutorForIndexJoin does not support physical selection, so it will throw wrong plan type for dataReaderBuilder error when meeting physical selection plan.

What is changed and how it works?

What's Changed:
support physical selection in buildExecutorForIndexJoin

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Integration test

Release note

  • fix Wrong plan type for dataReaderBuilder error

@sre-bot sre-bot requested a review from a team as a code owner May 8, 2020 06:39
@sre-bot
Copy link
Contributor Author

sre-bot commented May 8, 2020

/run-all-tests

@ghost ghost requested a review from wshwsh12 May 8, 2020 06:39
@sre-bot sre-bot mentioned this pull request May 8, 2020
Merged
@ghost ghost removed their request for review May 8, 2020 06:39
@sre-bot sre-bot requested review from lzmhhh123 and qw4990 May 8, 2020 06:39
@sre-bot sre-bot added this to the v4.0.0-rc.1 milestone May 8, 2020
qw4990
qw4990 reviewed May 8, 2020
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 modified the milestones: v4.0.0-rc.1, 4.0.0-rc.2 May 9, 2020
lzmhhh123
lzmhhh123 approved these changes May 9, 2020
View reviewed changes
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lzmhhh123 lzmhhh123 added the status/LGT2 Indicates that a PR has LGTM 2. label May 9, 2020
@zz-jason zz-jason changed the title executor: fix wrong plan type for dataReaderBuilder error (#17028) executor: fix wrong plan type for dataReaderBuilder... (#17028) May 9, 2020
@zz-jason zz-jason merged commit 75b3d09 into pingcap:release-4.0 May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 left review comments

@lzmhhh123 lzmhhh123 lzmhhh123 approved these changes

@wshwsh12 wshwsh12 Awaiting requested review from wshwsh12

Assignees

@windtalker windtalker

Labels
component/expression sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2. type/4.0-cherry-pick
Projects
None yet
Milestone
4.0.0-rc.2
Development

Successfully merging this pull request may close these issues.
6 participants
@sre-bot @qw4990 @lzmhhh123 @bb7133 @windtalker @zz-jason