Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: forbid truncating sequence object (#16981) #17037

Merged
merged 3 commits into from
May 9, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented May 8, 2020

cherry-pick #16981 to release-4.0


What problem does this PR solve?

Problem Summary: forbid truncating sequence object.

What is changed and how it works?

What's Changed: forbid truncating sequence object with truncate table seq

How it Works:
judge the truncated object in DDL worker

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Release note

  • ddl: forbid truncating sequence object

@sre-bot sre-bot requested a review from a team as a code owner May 8, 2020 06:57
@sre-bot
Copy link
Contributor Author

sre-bot commented May 8, 2020

/run-all-tests

@ghost ghost requested a review from SunRunAway May 8, 2020 06:57
@sre-bot sre-bot added sig/sql-infra SIG: SQL Infra sig/execution SIG execution type/4.0-cherry-pick type/bugfix This PR fixes a bug. labels May 8, 2020
@ghost ghost removed their request for review May 8, 2020 06:57
@sre-bot sre-bot added this to the v4.0.0-rc.1 milestone May 8, 2020
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AilinKid
Copy link
Contributor

AilinKid commented May 8, 2020

/buid

@AilinKid
Copy link
Contributor

AilinKid commented May 8, 2020

/run-common-test

@bb7133 bb7133 modified the milestones: v4.0.0-rc.1, 4.0.0-rc.2 May 9, 2020
@AilinKid
Copy link
Contributor

AilinKid commented May 9, 2020

/run-all-tests

@zimulala zimulala merged commit f9dd7fe into pingcap:release-4.0 May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution sig/sql-infra SIG: SQL Infra type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants