Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: do not choose point get when exists read from tiflash hint. #17046

Closed
wants to merge 7 commits into from
Closed

planner: do not choose point get when exists read from tiflash hint. #17046

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a6022c1
planner: do not choose point get when exists read from tiflash hint
lzmhhh123 May 8, 2020
49d8ddc
fix
lzmhhh123 May 8, 2020
d3deb75
address comment
lzmhhh123 May 12, 2020
baaeaa0
Update planner/core/point_get_plan.go
lzmhhh123 May 13, 2020
8075834
Merge branch 'master' into bug-fix/ban_point_get_tiflash_hint
lzmhhh123 May 28, 2020
844cf4d
Merge branch 'master' into bug-fix/ban_point_get_tiflash_hint
lzmhhh123 Aug 18, 2020
09bd0fa
Merge branch 'master' into bug-fix/ban_point_get_tiflash_hint
lzmhhh123 Dec 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion planner/core/point_get_plan.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,9 +541,13 @@ func newBatchPointGetPlan(
}.Init(ctx, statsInfo, schema, names, 0)
}

func isHintReadFromTiFlash(hint *ast.TableOptimizerHint) bool {
return hint.HintName.L == "read_from_storage" && hint.HintData.(model.CIStr).L == "tiflash"
lzmhhh123 marked this conversation as resolved.
Show resolved Hide resolved
}

func selStmtHasTiFlashHint(selStmt *ast.SelectStmt) bool {
for _, hint := range selStmt.TableHints {
if hint.HintName.L == "read_from_storage" && hint.HintData.(model.CIStr).L == "tiflash" {
if isHintReadFromTiFlash(hint) {
return true
}
}
Expand Down