Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sessionctx: record if a query hits plan cache in slow log (#17088) #17121

Merged
merged 2 commits into from
May 12, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented May 12, 2020

cherry-pick #17088 to release-4.0


What problem does this PR solve?

Issue Number: close #16197

Problem Summary:

Not a problem, this is an enhancement for diagnose purpose.

What is changed and how it works?

What's Changed:

Add new Plan_from_cache field in slow log.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

N/A

Release note

  • record if a query hits plan cache in slow log

@sre-bot sre-bot requested a review from a team as a code owner May 12, 2020 07:49
@sre-bot
Copy link
Contributor Author

sre-bot commented May 12, 2020

/run-all-tests

@sre-bot sre-bot added sig/sql-infra SIG: SQL Infra sig/execution SIG execution component/session type/4.0-cherry-pick type/enhancement The issue or PR belongs to an enhancement. labels May 12, 2020
@ghost ghost requested review from qw4990 and removed request for a team May 12, 2020 07:49
@sre-bot sre-bot added this to the 4.0.0-rc.2 milestone May 12, 2020
@eurekaka
Copy link
Contributor

/run-integration-copr-test

Copy link
Contributor

@danmay319 danmay319 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels May 12, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented May 12, 2020

/run-all-tests

@sre-bot sre-bot merged commit f5146b0 into pingcap:release-4.0 May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/session sig/execution SIG execution sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants