variables: return error when setting statement summary variables to invalid values (#17108) #17129
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #17108 to release-4.0
What problem does this PR solve?
Problem Summary:
System variables are transformed to a valid value according to min/max values. But this valid value is stored into TiKV, while the current server still uses the invalid value.
For example,
-1
is invalid and the value is transformed to1
when validating it, and1
is stored tomysql.global_variables
table. However, 1 is not returned in the currentSET
statement, and theSET
statement passes-1
to statement summary.What is changed and how it works?
What's Changed:
Throw an error when it's set to an invalid value. This is simple and reasonable.
Related changes
Check List
Tests
Side effects
Release note