Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: check plan type when executing explain format="dot". #17144

Merged
merged 8 commits into from
May 13, 2020

Conversation

LittleFall
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #17141

What is changed and how it works?

Check plan type when executing explain format="dot".

Check List

Tests

  • Unit test

Release note

Check plan type when executing explain format="dot".

@LittleFall LittleFall requested review from a team as code owners May 12, 2020 12:57
@ghost ghost requested review from wshwsh12 and francis0407 and removed request for a team May 12, 2020 12:57
@LittleFall LittleFall added type/enhancement The issue or PR belongs to an enhancement. sig/planner SIG: Planner labels May 12, 2020
@LittleFall
Copy link
Contributor Author

/run-all-tests

@github-actions github-actions bot added the sig/execution SIG execution label May 12, 2020
@LittleFall
Copy link
Contributor Author

/run-all-tests

@LittleFall LittleFall requested review from eurekaka and zz-jason and removed request for wshwsh12 and francis0407 May 12, 2020 13:35
@codecov
Copy link

codecov bot commented May 12, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@526a711). Click here to learn what that means.
The diff coverage is 0.0000%.

@@             Coverage Diff             @@
##             master     #17144   +/-   ##
===========================================
  Coverage          ?   80.0155%           
===========================================
  Files             ?        510           
  Lines             ?     139048           
  Branches          ?          0           
===========================================
  Hits              ?     111260           
  Misses            ?      18834           
  Partials          ?       8954           

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added priority/individual-blocker status/LGT1 Indicates that a PR has LGTM 1. labels May 12, 2020
@LittleFall LittleFall added needs-cherry-pick-3.0 type/bugfix This PR fixes a bug. and removed type/enhancement The issue or PR belongs to an enhancement. labels May 12, 2020
@LittleFall
Copy link
Contributor Author

/run-all-tests

@LittleFall
Copy link
Contributor Author

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 12, 2020
@sre-bot
Copy link
Contributor

sre-bot commented May 12, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented May 12, 2020

@LittleFall merge failed.

@LittleFall
Copy link
Contributor Author

/run-sqllogic-test-1

@LittleFall
Copy link
Contributor Author

/merge

@sre-bot
Copy link
Contributor

sre-bot commented May 12, 2020

/run-all-tests

@LittleFall
Copy link
Contributor Author

@zz-jason @SunRunAway Could you help me merge it? Thanks!

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 13, 2020
@zz-jason
Copy link
Member

/merge

@sre-bot
Copy link
Contributor

sre-bot commented May 13, 2020

/run-all-tests

@sre-bot sre-bot merged commit 44a894d into pingcap:master May 13, 2020
sre-bot pushed a commit to sre-bot/tidb that referenced this pull request May 13, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented May 13, 2020

cherry pick to release-3.0 in PR #17157

sre-bot pushed a commit to sre-bot/tidb that referenced this pull request May 13, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented May 13, 2020

cherry pick to release-3.1 in PR #17158

@sre-bot
Copy link
Contributor

sre-bot commented May 13, 2020

cherry pick to release-4.0 in PR #17160

@LittleFall LittleFall deleted the issue-17141 branch May 14, 2020 05:06
winoros added a commit that referenced this pull request Jul 27, 2020
…) (#17157)

Co-authored-by: Zhi Qi <30543181+LittleFall@users.noreply.github.com>
Co-authored-by: Yiding Cui <winoros@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

planner: refine the infomation when execute desc format="dot" for core.Explain.
4 participants