Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix flashback table faild in uppercase d ... (#17093) #17167

Merged
merged 4 commits into from
May 14, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented May 13, 2020

cherry-pick #17093 to release-4.0


Signed-off-by: crazycs520 crazycs520@gmail.com

What problem does this PR solve?

Fix below bugs:

drop database if exists Test2;
create database Test2;
use Test2;
create table t (a int);
drop table t;
flashback table t; -- should execute successfully.
(1105, u"Can't find dropped/truncated table: t in DDL history jobs")

drop table t;
drop database if exists Test3;
create database Test3;
use Test3;
create table t (a int);
drop table t;
drop database Test3;
use Test2;
flashback table t; -- should execute successfully.
(1049, u"Unknown database '(Schema ID 62)'")

What is changed and how it works?

No

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Side effects

  • No

Release note

  • Fix flashback table failed in some special cases.

@sre-bot sre-bot requested a review from a team as a code owner May 13, 2020 07:00
@sre-bot
Copy link
Contributor Author

sre-bot commented May 13, 2020

/run-all-tests

@sre-bot sre-bot added sig/sql-infra SIG: SQL Infra sig/execution SIG execution type/4.0-cherry-pick type/bugfix This PR fixes a bug. labels May 13, 2020
@ghost ghost requested review from SunRunAway and removed request for a team May 13, 2020 07:00
@sre-bot sre-bot requested review from tangenta and zimulala May 13, 2020 07:00
@sre-bot sre-bot added this to the 4.0.0-rc.2 milestone May 13, 2020
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels May 14, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented May 14, 2020

Your auto merge job has been accepted, waiting for:

  • 17118
  • 17107
  • 16165
  • 17003
  • 17126
  • 17164

@sre-bot
Copy link
Contributor Author

sre-bot commented May 14, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented May 14, 2020

@sre-bot merge failed.

@crazycs520
Copy link
Contributor

/run-integration-copr-test

@zz-jason
Copy link
Member

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented May 14, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented May 14, 2020

@sre-bot merge failed.

@zz-jason zz-jason changed the title executor: fix flashback table faild in uppercase database name (#17093) executor: fix flashback table faild in uppercase d ... (#17093) May 14, 2020
@zz-jason zz-jason merged commit d23fb6a into pingcap:release-4.0 May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants