Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: make 'alter table reorganize partition' report error (#17020) #17178

Merged
merged 1 commit into from
May 13, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented May 13, 2020

cherry-pick #17020 to release-4.0


What problem does this PR solve?

create table t ( id int, fname varchar(25), lname varchar(25), dob date) partition by range( year(dob) ) (
    partition p0 values less than (1980),
    partition p1 values less than (1990),
    partition p2 values less than (2000),
    partition p3 values less than maxvalue
);

alter table t reorganize partition p0 into (
    partition n0 values less than (1970),
    partition n1 values less than (1980)
);

This operation is not supported yet, return an error explicitly is better that simply ignore the statement.

What is changed and how it works?

Proposal: xxx

What's Changed:

Make 'alter table reorganize partition' report error.

How it Works:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • PR to update pingcap/tidb-ansible:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

Release note

  • alter table reorganize partition is not implemented, report error explicitly for this operation

)

This operation is not supported yet, return an error explicitly is better
that simply ignore the statement.
@sre-bot
Copy link
Contributor Author

sre-bot commented May 13, 2020

/run-all-tests

@sre-bot sre-bot added compatibility-breaker Violation of forwards/backwards compatibility in a design-time piece. sig/sql-infra SIG: SQL Infra type/4.0-cherry-pick labels May 13, 2020
@sre-bot sre-bot requested review from jackysp and zimulala May 13, 2020 11:01
@sre-bot sre-bot added this to the 4.0.0-rc.2 milestone May 13, 2020
@tiancaiamao
Copy link
Contributor

/run-integration-ddl-test
@zimulala @jackysp

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label May 13, 2020
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp
Copy link
Member

jackysp commented May 13, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 13, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented May 13, 2020

/run-all-tests

@sre-bot sre-bot merged commit 6c7b4dc into pingcap:release-4.0 May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility-breaker Violation of forwards/backwards compatibility in a design-time piece. sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants