Util: Fix global tracker mutex contention (#16298) #17234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
/run-all-tests |
ghost
requested a review
from
|
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
|
Please resolve the conflicts, @Yisaer . |
Util: Fix global tracker mutex contention
|
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
|
/rebuild |
|
Conflict fixed, but I can't edit the release-note. |
|
/run-unit-test |
|
LGTM |
|
/run-check_dev |
|
/run-unit-test |
|
LGTM |
|
/run-check_dev |
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
/run-unit-test |
|
/approve |
|
Approve failed. |
|
/approve |
|
Approve failed. |
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
|
/run-unit-test |
This comment has been minimized.
This comment has been minimized.
|
@sre-bot merge failed. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 similar comments
|
/run-unit-test |
|
/run-unit-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #16298 to release-4.0
What problem does this PR solve?
For the Global Tracker, the Attaching and Detaching would cause the mutex contention which would decrease the qps.
Issue Number: close #16258
Problem Summary:
What is changed and how it works?
How it Works:
Import the Global function in the Tracker. It remove the logic to maintain the children to avoid mutex contention
Related changes
Check List
Tests
Release note