expensivequery: fix the issue that max_exec_time hint doesn't work if it exceeds the expensive-threshold (#17359) #17536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
/run-all-tests |
sre-bot
added
sig/execution
ghost
requested a review
from 
XuHuaiyu
requested review from
zz-jason and
qw4990
and removed request for
SunRunAway
zz-jason
added
status/can-merge
|
/run-all-tests |
|
@sre-bot merge failed. |
|
/merge |
|
/merge |
|
/run-all-tests |
|
@sre-bot merge failed. |
|
/run-all-tests |
|
@sre-bot merge failed. |
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@sre-bot merge failed. |
|
@sre-bot, please update your pull request. |
|
/merge |
|
Sorry @XuHuaiyu, you don't have permission to trigger auto merge event on this branch. |
|
/merge |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #17359 to release-4.0
What problem does this PR solve?
Issue Number: close #17355, close #17393
Problem Summary:
1. Minimal reproduce step (Required)
set @@max_execution_time=60000;
select sleep(70);
2. What did you expect to see? (Required)
mysql> select sleep(70);
+-----------+
| sleep(70) |
+-----------+
| 1 |
+-----------+
1 row in set (1 min )
3. What did you see instead (Required)
What is changed and how it works?
What's Changed:
repair max_execution_time sometimes fails.
How it Works:
The MaxExecutionTime and ExceedExpensiveTimeThresh check logic separately.
Related changes
cherry-pick: V3.0,V3.1,V4.0
Check List
Tests
Release note