Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bindinfo, record how bindings are created in SQL bindings. (#17254) #17587

Merged
merged 6 commits into from
Jun 2, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Jun 2, 2020

cherry-pick #17254 to release-4.0


What problem does this PR solve?

Issue Number: close #16748

Problem Summary:

What is changed and how it works?

What's Changed:

  • add domain CreateWay in Binding to indicate the way binding created.
  • show CreateWay when execute show [global] bindings

How it Works:

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Performance regression
    • Consumes more MEM

Release note

  • add domain CreateWay in Binding to help know the way binding created.

Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor Author

sre-bot commented Jun 2, 2020

/run-all-tests

Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danmay319 danmay319 added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 2, 2020
@danmay319
Copy link
Contributor

PTAL~ @zz-jason

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 2, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Jun 2, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Jun 2, 2020

@sre-bot merge failed.

@zz-jason
Copy link
Member

zz-jason commented Jun 2, 2020

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Jun 2, 2020

Your auto merge job has been accepted, waiting for:

  • 17498
  • 17562
  • 17330
  • 17301
  • 17256
  • 17202
  • 17350
  • 17594

@sre-bot
Copy link
Contributor Author

sre-bot commented Jun 2, 2020

/run-all-tests

@sre-bot sre-bot merged commit f590e7d into pingcap:release-4.0 Jun 2, 2020
@bb7133 bb7133 modified the milestones: v4.0.1, v4.0.2 Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution sig/planner SIG: Planner sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants