Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: push down expr json_length to tiflash (#17588) #17592

Merged
merged 2 commits into from
Jun 2, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Jun 2, 2020

cherry-pick #17588 to release-4.0


Signed-off-by: Tong Zhigao tongzhigao@pingcap.com

What problem does this PR solve?

What is changed and how it works?

What's Changed:

  • Add json_length to white list which can be pushed down to tiflash.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Release note

  • No release note

Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor Author

sre-bot commented Jun 2, 2020

/run-all-tests

Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@solotzg
Copy link
Contributor

solotzg commented Jun 2, 2020

/run-all-tests

1 similar comment
@solotzg
Copy link
Contributor

solotzg commented Jun 2, 2020

/run-all-tests

Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@solotzg
Copy link
Contributor

solotzg commented Jun 2, 2020

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Jun 2, 2020

Sorry @solotzg, you don't have permission to trigger auto merge event on this branch.

@lzmhhh123 lzmhhh123 added the status/can-merge Indicates a PR has been approved by a committer. label Jun 2, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Jun 2, 2020

Sorry @lzmhhh123, you don't have permission to trigger auto merge event on this branch.

@SunRunAway SunRunAway added status/can-merge Indicates a PR has been approved by a committer. and removed status/can-merge Indicates a PR has been approved by a committer. labels Jun 2, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Jun 2, 2020

/run-all-tests

@sre-bot sre-bot merged commit dd83050 into pingcap:release-4.0 Jun 2, 2020
@bb7133 bb7133 modified the milestones: v4.0.1, v4.0.2 Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression status/can-merge Indicates a PR has been approved by a committer. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants