*: fix a bug that collation does not work for enum and set #17635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
|
/rebuild |
Codecov Report
@@ Coverage Diff @@
## master #17635 +/- ##
===========================================
Coverage 79.4724% 79.4724%
===========================================
Files 524 524
Lines 141142 141142
===========================================
Hits 112169 112169
Misses 19914 19914
Partials 9059 9059 |
|
/run-unit-test |
1 similar comment
|
/run-unit-test |
wjhuang2016
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
/run-all-tests |
|
@wjhuang2016 merge failed. |
|
/merge |
|
/run-all-tests |
|
@wjhuang2016 merge failed. |
|
/run-common-test |
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Jun 5, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-4.0 in PR #17701 |
bb7133
pushed a commit
that referenced
this pull request
Jun 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #17634
Problem Summary:
In convertToMysqlEnum and convertToMysqlSet, we didn't consider collation and used
ToLower.What is changed and how it works?
Use
collatorto compare.Related changes
Check List
Tests
Side effects
Release note