Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: split partition region when add a new partition (#16537) #17668

Merged
merged 2 commits into from
Jun 5, 2020
Merged

ddl: split partition region when add a new partition (#16537) #17668

merged 2 commits into from
Jun 5, 2020

Conversation

tiancaiamao
Copy link
Contributor

What problem does this PR solve?

Cherry-pick #16537 to release-3.0

Release note

  • Split partition region when adding a new partition

@tiancaiamao
Copy link
Contributor Author

PTAL @zimulala @crazycs520

@tiancaiamao tiancaiamao mentioned this pull request Jun 4, 2020
Closed
zimulala
zimulala reviewed Jun 4, 2020
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 4, 2020
@github-actions github-actions bot added sig/sql-infra SIG: SQL Infra sig/execution SIG execution labels Jun 4, 2020
@tiancaiamao tiancaiamao modified the milestones: 3.0.16, v3.0.16 Jun 4, 2020
crazycs520
crazycs520 approved these changes Jun 4, 2020
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133
Copy link
Member

bb7133 commented Jun 5, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 5, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jun 5, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jun 5, 2020

@tiancaiamao merge failed.

@bb7133
Copy link
Member

bb7133 commented Jun 5, 2020

/run-unit-test

@bb7133
Copy link
Member

bb7133 commented Jun 5, 2020 

 1778 [2020-06-05T02:41:01.810Z] ----------------------------------------------------------------------
 1779 [2020-06-05T02:41:01.810Z] FAIL: lock_test.go:206: testLockSuite.TestCheckTxnStatusTTL
 1780 [2020-06-05T02:41:01.810Z] 
 1781 [2020-06-05T02:41:01.810Z] lock_test.go:218:
 1782 [2020-06-05T02:41:01.810Z]     c.Assert(status.ttl, Greater, uint64(0))
 1783 [2020-06-05T02:41:01.810Z] ... compare_one uint64 = 0x0                                              1784 [2020-06-05T02:41:01.810Z] ... compare_two uint64 = 0x0
 1785 [2020-06-05T02:41:01.810Z]

https://internal.pingcap.net/idc-jenkins/blue/organizations/jenkins/tidb_ghpr_unit_test/detail/tidb_ghpr_unit_test/38798/pipeline

@bb7133 bb7133 merged commit 9b915a7 into pingcap:release-3.0 Jun 5, 2020
@bb7133 bb7133 modified the milestones: v3.0.16, 3.0.16 Jun 6, 2020
@qw4990 qw4990 added the status/LGT2 Indicates that a PR has LGTM 2. label Jun 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala left review comments

@crazycs520 crazycs520 crazycs520 approved these changes

Assignees
No one assigned
Labels
sig/execution SIG execution sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/LGT2 Indicates that a PR has LGTM 2. type/3.0-cherry-pick
Projects
None yet
Milestone
v3.0.16
Development

Successfully merging this pull request may close these issues.
6 participants
@tiancaiamao @bb7133 @sre-bot @zimulala @crazycs520 @qw4990