expression: Fix the wrong behavior of const.String() (#17495) #17673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
/run-all-tests |
sre-bot
added
component/expression
type/4.0-cherry-pick
type/bugfix
sre-bot
requested review from
danmay319,
qw4990,
SunRunAway,
XuHuaiyu and
zz-jason
|
/run-integration-copr-test |
|
/merge |
|
Sorry @Reminiscent, you don't have permission to trigger auto merge event on this branch. |
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
|
@sre-bot merge failed. |
|
/run-unit-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #17495 to release-4.0
What problem does this PR solve?
Issue Number: close #17287
Problem Summary:
const.String()is wrong.const.DeferredExpr != nil, we need to use the passed function parameterchunk.rowforEval, instead of using an emptychunk.Row.What is changed and how it works?
Use the
const.DeferredExpr.String()rather than to eval theconst.Use the function parameter
chunk.rowforEvalinstead of an emptychunk.Row().Related changes
Check List
Tests
Release note