expression: pushdown expr to tiflash without check new collation status #17683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #17683 +/- ##
================================================
- Coverage 79.6119% 79.4885% -0.1234%
================================================
Files 525 524 -1
Lines 143623 141443 -2180
================================================
- Hits 114341 112431 -1910
+ Misses 20105 19947 -158
+ Partials 9177 9065 -112 |
lzmhhh123
added
needs-cherry-pick-4.0
status/LGT1
wshwsh12
added
status/LGT2
|
/run-all-tests |
|
@windtalker merge failed. |
|
/run-unit-test |
|
/run-all-tests |
|
/run-check_dev_2 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Jun 5, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-4.0 in PR #17705 |
SunRunAway
pushed a commit
that referenced
this pull request
Jun 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Currently, TiDB does not push down expr to TiFlash if new collation is enabled because TiFlash does not support new collation. Now new collation is supported in TiFlash, so we do not need this check anymore.
What is changed and how it works?
What's Changed:
TiDB not check collation status when trying to pushdown expr to TiFlash
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Release note