failpoint: update failpoint (#17628) #17710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
/run-all-tests |
sre-bot
added
component/test
type/3.0-cherry-pick
type/bugfix
zimulala
reviewed
Jun 8, 2020
Signed-off-by: AilinKid <314806019@qq.com>
|
@zimulala @djshow832 PTAL |
|
/run-all-tests |
|
/run-all-tests |
zimulala
added
the
status/can-merge
|
Sorry @zimulala, you don't have permission to trigger auto merge event on this branch. |
zimulala
approved these changes
Jun 9, 2020
|
/merge |
|
Sorry @zimulala, you don't have permission to trigger auto merge event on this branch. |
|
/run-sqllogic-test-1 |
|
@bb7133 PTAL |
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@sre-bot merge failed. |
|
/run-all-tests |
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #17628 to release-3.0
Signed-off-by: AilinKid 314806019@qq.com
What problem does this PR solve?
Related failpoint PR: pingcap/failpoint#58
Problem Summary:
Fix go failpoint data race in TiDB test case.
1: when
*CustomParallelSuiteFlag = trueis set, the tests in differentSuitewill run parallelly.2: when a test arrived
Enable(), when another arrivedEval()will cause data race in failpoint.For more detail:
1: see https://internal.pingcap.net/idc-jenkins/blue/organizations/jenkins/tidb_ghpr_unit_test/detail/tidb_ghpr_unit_test/38125/pipeline/
2: Also fixes #17625
What is changed and how it works?
What's Changed: update go.mod
Check List
Tests
Release note