expression: fix the panic when we use unix_time expression in prepare and execute statement.
#17855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjhuang2016
reviewed
Jun 9, 2020
Reminiscent
changed the title
unix_time expression in prepare and execute statement.
|
@lysu PTAL |
winoros
reviewed
Jun 12, 2020
There was a problem hiding this comment.
The current impl is not the same thing as your PR's description.
Why just take the UNIX_TIMESTAMP into special consideration?
@Reminiscent
|
@winoros It's my mistake, I have updated the PR description. |
� Conflicts: � expression/integration_test.go
zz-jason
added
status/LGT1
Codecov Report
@@ Coverage Diff @@
## master #17855 +/- ##
===========================================
Coverage 79.4785% 79.4785%
===========================================
Files 524 524
Lines 142168 142168
===========================================
Hits 112993 112993
Misses 20033 20033
Partials 9142 9142 |
zz-jason
reviewed
Jun 12, 2020
zz-jason
approved these changes
Jun 15, 2020
zz-jason
added
needs-cherry-pick-4.0
status/can-merge
|
/run-all-tests |
|
/run-all-tests |
|
@Reminiscent merge failed. |
|
/merge |
|
/run-all-tests |
|
@Reminiscent merge failed. |
|
/merge |
|
/run-all-tests |
|
@Reminiscent merge failed. |
|
/merge |
|
/run-all-tests |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Jun 15, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-4.0 in PR #18002 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #17727
Problem Summary:
When we set
prepare-plan-cache = trueand useprepare && executestatement. Some time-related expression such asnow()will be wrapped intoconstant.deferredExprfor delayed calculation. But the expressionunix_timestampis special. When there is no parameter, it should be placed inconstant.deferredExprfor delay calculation. If there is a parameter, it should not be put intoconstant.deferredExpr, otherwise, it will cause access tonilpointerWhat is changed and how it works?
Special handling of the case of the expression
unix_timestampforfuncCallToExpression.Related changes
Check List
Tests
Release note
unix_timeexpression inprepare and executestatement.