sessionctx: add optimization-time and wait-TS-time into the slow log #17869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
|
/run-unit-test |
Codecov Report
@@ Coverage Diff @@
## master #17869 +/- ##
================================================
- Coverage 79.6139% 79.4335% -0.1805%
================================================
Files 525 524 -1
Lines 142946 141585 -1361
================================================
- Hits 113805 112466 -1339
- Misses 19997 20019 +22
+ Partials 9144 9100 -44 |
github-actions
bot
added
sig/sql-infra
crazycs520
reviewed
Jun 9, 2020
executor/builder.go
Outdated
| txn, err := b.ctx.Txn(true) | ||
| b.ctx.GetSessionVars().DurationWaitTS = time.Since(begin) |
There was a problem hiding this comment.
Put this into ctx.Txn will more accuracy？ maybe already active the transaction before here.
There was a problem hiding this comment.
Updated. PTAL @crazycs520 .
qw4990
added
the
status/can-merge
|
/run-all-tests |
|
@qw4990 merge failed. |
|
/run-common-test |
3 similar comments
|
/run-common-test |
|
/run-common-test |
|
/run-common-test |
|
/run-all-tests |
|
/run-integration-copr-test |
|
cherry pick to release-4.0 in PR #22918 |
crazycs520
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Mar 3, 2021
ti-chi-bot
pushed a commit
that referenced
this pull request
Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: related to #17557
Problem Summary: add optimization-time and wait-TS-time into the slow log
What is changed and how it works?
One step to resolve #17557.
Add optimization-time and wait-TS-time into the slow log.
Check List
Tests
Release note