expression: fix the bug of vectorized case when #17879
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winoros
reviewed
Jun 11, 2020
| @@ -64,7 +66,8 @@ func (b *builtinCaseWhen{{ .TypeName }}Sig) vecEval{{ .TypeName }}(input *chunk. | |||
| thensSlice := make([][]{{.TypeNameGo}}, l/2) | |||
| var eLseSlice []{{.TypeNameGo}} | |||
| {{- end }} | |||
|
|
|||
| allErrs := make([][]error,l/2) | |||
|
#19367 close this. |
fzhedu
commented
Aug 28, 2020
| @@ -82,30 +85,111 @@ func (b *builtinCaseWhen{{ .TypeName }}Sig) vecEval{{ .TypeName }}(input *chunk. | |||
| return err | |||
There was a problem hiding this comment.
VecEvalInt() dose not return error[]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #17725
Problem Summary: the vectorized execution runs each branch, some of them cause unnecessary errors.
What is changed and how it works?
What's Changed: record all errors, and add a parameter to avoid the warning.
Related changes
Check List
Tests
Side effects
Release note