Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: complete the list of deprecated configurations (#18001) #18046

Merged
merged 5 commits into from
Jul 15, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #18001 to release-4.0


What problem does this PR solve?

When upgrading from v3.0, check-config will fail due to some deprecated configs not listed in deprecatedConfig. This PR complete this list.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • PR to update pingcap/tidb-ansible:
  • Need to cherry-pick to the release branch

Check List

Tests

  • No code

Release note

  • Make the configuration checker compatible with older versions of the configuration

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@jackysp
Copy link
Member

jackysp commented Jun 17, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 17, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@jackysp
Copy link
Member

jackysp commented Jun 17, 2020

/run-integration-copr-test

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason modified the milestones: v4.0.2, v4.0.3 Jun 19, 2020
@tiancaiamao
Copy link
Contributor

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 7, 2020
@ti-srebot
Copy link
Contributor Author

@tiancaiamao,Thanks for your review.

@tiancaiamao tiancaiamao added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 7, 2020
@bobotu
Copy link
Contributor

bobotu commented Jul 14, 2020

/merge

@ti-srebot
Copy link
Contributor Author

Sorry @bobotu, you don't have permission to trigger auto merge event on this branch.

@coocood
Copy link
Member

coocood commented Jul 14, 2020

/merge

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@jackysp
Copy link
Member

jackysp commented Jul 14, 2020

/merge

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@bobotu
Copy link
Contributor

bobotu commented Jul 15, 2020

/run-check_dev

@bobotu
Copy link
Contributor

bobotu commented Jul 15, 2020

@jackysp @coocood Can we merge this PR manually?

@coocood
Copy link
Member

coocood commented Jul 15, 2020

/merge

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit 8ef07a5 into pingcap:release-4.0 Jul 15, 2020
@coocood coocood deleted the release-4.0-50bd9f486779 branch July 15, 2020 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/config status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants