Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix plan cache statistic result. #18067

Merged
merged 3 commits into from
Jun 18, 2020
Merged

Conversation

danmay319
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #18066

Problem Summary:

What is changed and how it works?

What's Changed:

  • Clear planInCache if PlanInCache is false.

How it Works:

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Side effects

Release note

    • Clear sei.planInCache if PlanInCache is false.

@danmay319 danmay319 requested a review from a team as a code owner June 18, 2020 02:13
@codecov
Copy link

codecov bot commented Jun 18, 2020

Codecov Report

Merging #18067 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #18067   +/-   ##
===========================================
  Coverage   79.6091%   79.6091%           
===========================================
  Files           526        526           
  Lines        144413     144413           
===========================================
  Hits         114966     114966           
  Misses        20170      20170           
  Partials       9277       9277           

Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/can-merge Indicates a PR has been approved by a committer. label Jun 18, 2020
@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 18076

Copy link
Contributor

@Reminiscent Reminiscent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danmay319 danmay319 added the status/LGT3 The PR has already had 3 LGTM. label Jun 18, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@lawyerphx merge failed.

@danmay319
Copy link
Contributor Author

/rebuild

@danmay319
Copy link
Contributor Author

/run-integration-br-tests

1 similar comment
@danmay319
Copy link
Contributor Author

/run-integration-br-tests

@danmay319
Copy link
Contributor Author

/merge

@ti-srebot
Copy link
Contributor

Sorry @lawyerphx, you don't have permission to trigger auto merge event on this branch. You are not a committer

@danmay319
Copy link
Contributor Author

Please help merge @zz-jason .

@zz-jason zz-jason merged commit 7c49049 into pingcap:master Jun 18, 2020
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 18, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #18111

ngaut pushed a commit that referenced this pull request Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic/plan-cache sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT3 The PR has already had 3 LGTM.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

planner: plan cache statistic result is not correct.
5 participants