Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: add config EnableCollectExecutionInfo (#15493) #18073

Merged
merged 3 commits into from
Jun 17, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #15493 to release-4.0


Signed-off-by: TennyZhuang zty0826@gmail.com

What problem does this PR solve?

This is the first PR of #15008

What is changed and how it works?

Add config EnableCollectExecutionInfo

Related changes

Check List

Tests

  • Unit test

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM

Release note

Add config EnableCollectExecutionInfo

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@qw4990 please accept the invitation then you can push to the cherry-pick pull requests.
https://github.com/ti-srebot/tidb/invitations

Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added the status/can-merge Indicates a PR has been approved by a committer. label Jun 17, 2020
@ti-srebot
Copy link
Contributor Author

Sorry @qw4990, you don't have permission to trigger auto merge event on this branch.

@crazycs520 crazycs520 merged commit bb4138e into pingcap:release-4.0 Jun 17, 2020
@jackysp jackysp removed the contribution This PR is from a community contributor. label Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/config sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants