-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: remove sensitive information in slow-log and statement (#18107) #18130
Merged
bb7133
merged 2 commits into
pingcap:release-4.0
from
ti-srebot:release-4.0-dfca52cb0b64
Jun 19, 2020
Merged
executor: remove sensitive information in slow-log and statement (#18107) #18130
bb7133
merged 2 commits into
pingcap:release-4.0
from
ti-srebot:release-4.0-dfca52cb0b64
Jun 19, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
/run-all-tests |
ti-srebot
added
sig/sql-infra
SIG: SQL Infra
sig/execution
SIG execution
security
Everything related with security
type/4.0-cherry-pick
labels
Jun 19, 2020
Please resolve the conflict |
Signed-off-by: crazycs520 <crazycs520@gmail.com>
bb7133
reviewed
Jun 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bb7133
added
status/LGT1
Indicates that a PR has LGTM 1.
and removed
sig/sql-infra
SIG: SQL Infra
labels
Jun 19, 2020
/run-all-tests |
@kennytm PTAL |
/run-sqllogic-test-2 |
bb7133
approved these changes
Jun 19, 2020
wjhuang2016
reviewed
Jun 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
security
Everything related with security
sig/execution
SIG execution
sig/sql-infra
SIG: SQL Infra
status/LGT1
Indicates that a PR has LGTM 1.
type/4.0-cherry-pick
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #18107 to release-4.0
Signed-off-by: crazycs520 crazycs520@gmail.com
What problem does this PR solve?
Before this PR, TiDB slow log will record sensitive information such as passwords in slow-log query.
This PR remove sensitive information in slow-log. Such as below:
execute below sql:
The related slow-log will be:
the related statement will be:
What is changed and how it works?
Proposal: xxx
What's Changed:
How it Works:
Related changes
Check List
Tests
Side effects
Release note