-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: fix issue pre_split_regions
table option doesn't work in the partition table.
#18144
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #18144 +/- ##
===========================================
Coverage 79.6450% 79.6450%
===========================================
Files 535 535
Lines 145100 145100
===========================================
Hits 115565 115565
Misses 20261 20261
Partials 9274 9274 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@zimulala,Thanks for you review. |
/run-all-tests |
@crazycs520 merge failed. |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-4.0 in PR #18837 |
Signed-off-by: crazycs520 crazycs520@gmail.com
What problem does this PR solve?
Close #14478
When create partition table, the
pre_split_regions
table option doesn't work.After create table, before this PR, TiDB only split 1 regino for the separate partition:
In this PR, every partition of the table will have 4 regions.
What is changed and how it works?
Related changes
Check List
Tests
Side effects
Release note
pre_split_regions
table option doesn't work in the partition table.