ddl: stabilize test TestIndexChange #18228

wjhuang2016 · 2020-06-28T04:03:03Z

Signed-off-by: wjhuang2016 huangwenjun1997@gmail.com

What problem does this PR solve?

Issue Number: close #15531

[2020-06-30T07:13:16.416Z] ----------------------------------------------------------------------

[2020-06-30T07:13:16.416Z] FAIL: index_change_test.go:54: testIndexChangeSuite.TestIndexChange

[2020-06-30T07:13:16.416Z] 

[2020-06-30T07:13:16.416Z] index_change_test.go:174:

[2020-06-30T07:13:16.416Z]     c.Check(errors.ErrorStack(checkErr), Equals, "")

[2020-06-30T07:13:16.416Z] ... obtained string = "" +

[2020-06-30T07:13:16.416Z] ...     "index should have been dropped\n" +

[2020-06-30T07:13:16.416Z] ...     "github.com/pingcap/tidb/ddl.(*testIndexChangeSuite).TestIndexChange.func2\n" +

[2020-06-30T07:13:16.416Z] ...     "\t/home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/ddl/index_change_test.go:169\n" +

[2020-06-30T07:13:16.416Z] ...     "github.com/pingcap/tidb/ddl.(*TestDDLCallback).OnJobUpdated\n" +

[2020-06-30T07:13:16.416Z] ...     "\t/home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/ddl/callback_test.go:72\n" +

[2020-06-30T07:13:16.416Z] ...     "github.com/pingcap/tidb/ddl.(*worker).handleDDLJobQueue\n" +

[2020-06-30T07:13:16.416Z] ...     "\t/home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/ddl/ddl_worker.go:511\n" +

[2020-06-30T07:13:16.416Z] ...     "github.com/pingcap/tidb/ddl.(*worker).start\n" +

[2020-06-30T07:13:16.416Z] ...     "\t/home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/ddl/ddl_worker.go:155\n" +

[2020-06-30T07:13:16.416Z] ...     "runtime.goexit\n" +

[2020-06-30T07:13:16.416Z] ...     "\t/usr/local/go/src/runtime/asm_amd64.s:1357"

[2020-06-30T07:13:16.416Z] ... expected string = ""

[2020-06-30T07:13:16.416Z] 

[2020-06-30T07:13:16.416Z] PASS: column_change_test.go:61: testColumnChangeSuite.TestColumnChange	0.971s

Problem Summary:

testCreateIndex may not finish. If we set prevState = model.StateNone, then in the first onJobUpdated, it may change prevState to StatePublic.

What is changed and how it works?

Wait for the first onJobUpdated finish.

Related changes

Need to cherry-pick to the release branch

Check List

Tests

No code

Side effects

Release note

No release note

Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>

zimulala

Could you add the information that this test failed to PR description? I see there is only connections in the issue, but connections failed to open.

wjhuang2016 · 2020-07-08T06:15:11Z

Could you add the information that this test failed to PR description? I see there is only connections in the issue, but connections failed to open.

DONE

codecov · 2020-07-09T04:36:13Z

Codecov Report

Merging #18228 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #18228   +/-   ##
===========================================
  Coverage   79.6502%   79.6502%           
===========================================
  Files           549        549           
  Lines        150508     150508           
===========================================
  Hits         119880     119880           
  Misses        21099      21099           
  Partials       9529       9529

ddl/index_change_test.go

zimulala

testCreateIndex may not finish.

This job is in the history job queue(see checkHistoryJobArgs), then this operation should have been processed.

Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>

zimulala

LGTM

bb7133

LGTM

Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>

…tIndexChange

bb7133 · 2020-08-03T10:58:50Z

/merge

ti-srebot · 2020-08-03T11:00:39Z

/run-all-tests

ti-srebot · 2020-08-03T11:02:43Z

@wjhuang2016 merge failed.

bb7133 · 2020-08-03T11:10:38Z

/run-common-test

bb7133 · 2020-08-03T11:28:13Z

/run-unit-test

bb7133 · 2020-08-03T12:00:06Z

/merge

ti-srebot · 2020-08-03T12:00:30Z

/run-all-tests

ti-srebot · 2020-08-03T12:06:31Z

@wjhuang2016 merge failed.

bb7133 · 2020-08-03T12:30:55Z

/run-unit-test

done

652b999

Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>

github-actions bot added the sig/sql-infra SIG: SQL Infra label Jun 28, 2020

zimulala added the component/test label Jun 30, 2020

zimulala modified the milestones: 持续性啧啧啧 p]`\-099lkkiuyyyyytq11122234yzg, pools Jun 30, 2020

zimulala reviewed Jun 30, 2020

View reviewed changes

bb7133 reviewed Jul 14, 2020

View reviewed changes

ddl/index_change_test.go Show resolved Hide resolved

zimulala reviewed Jul 14, 2020

View reviewed changes

add comment

76a56c2

Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>

wjhuang2016 force-pushed the Fix_TestIndexChange branch from 0bcfd37 to 76a56c2 Compare July 17, 2020 08:30

wjhuang2016 requested review from bb7133 and zimulala July 21, 2020 08:37

zimulala reviewed Jul 24, 2020

View reviewed changes

ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 24, 2020

bb7133 previously approved these changes Jul 24, 2020

View reviewed changes

ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 24, 2020

ti-srebot previously approved these changes Jul 24, 2020

View reviewed changes

wjhuang2016 added 2 commits August 3, 2020 18:57

fix test

4fa0119

Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>

Merge branch 'master' of https://github.com/pingcap/tidb into Fix_Tes…

d2ff976

…tIndexChange

wjhuang2016 dismissed stale reviews from ti-srebot and bb7133 via d2ff976 August 3, 2020 10:57

wjhuang2016 force-pushed the Fix_TestIndexChange branch from 551af76 to d2ff976 Compare August 3, 2020 10:57

ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 3, 2020

bb7133 approved these changes Aug 3, 2020

View reviewed changes

Merge branch 'master' into Fix_TestIndexChange

5623323

bb7133 added the status/all-tests-passed label Aug 3, 2020

bb7133 merged commit 80aa5f9 into pingcap:master Aug 3, 2020

wjhuang2016 deleted the Fix_TestIndexChange branch November 17, 2022 11:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ddl: stabilize test TestIndexChange #18228

ddl: stabilize test TestIndexChange #18228

wjhuang2016 commented Jun 28, 2020 •

edited

Loading

zimulala left a comment

wjhuang2016 commented Jul 8, 2020

codecov bot commented Jul 9, 2020 •

edited

Loading

zimulala left a comment

zimulala left a comment

bb7133 left a comment

bb7133 commented Aug 3, 2020

ti-srebot commented Aug 3, 2020

ti-srebot commented Aug 3, 2020

bb7133 commented Aug 3, 2020

bb7133 commented Aug 3, 2020

bb7133 commented Aug 3, 2020

ti-srebot commented Aug 3, 2020

ti-srebot commented Aug 3, 2020

bb7133 commented Aug 3, 2020

ddl: stabilize test TestIndexChange #18228

ddl: stabilize test TestIndexChange #18228

Conversation

wjhuang2016 commented Jun 28, 2020 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Related changes

Check List

Release note

zimulala left a comment

Choose a reason for hiding this comment

wjhuang2016 commented Jul 8, 2020

codecov bot commented Jul 9, 2020 • edited Loading

Codecov Report

zimulala left a comment

Choose a reason for hiding this comment

zimulala left a comment

Choose a reason for hiding this comment

bb7133 left a comment

Choose a reason for hiding this comment

bb7133 commented Aug 3, 2020

ti-srebot commented Aug 3, 2020

ti-srebot commented Aug 3, 2020

bb7133 commented Aug 3, 2020

bb7133 commented Aug 3, 2020

bb7133 commented Aug 3, 2020

ti-srebot commented Aug 3, 2020

ti-srebot commented Aug 3, 2020

bb7133 commented Aug 3, 2020

wjhuang2016 commented Jun 28, 2020 •

edited

Loading

codecov bot commented Jul 9, 2020 •

edited

Loading