server: return the actual error when conn panic #18494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuHuaiyu
added
type/bugfix
|
@SunRunAway,Thanks for your review. |
ti-srebot
approved these changes
Jul 13, 2020
|
@lysu,Thanks for your review. |
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #18494 +/- ##
===========================================
Coverage 79.8641% 79.8641%
===========================================
Files 540 540
Lines 147046 147046
===========================================
Hits 117437 117437
Misses 20328 20328
Partials 9281 9281 |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jul 13, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-3.0 in PR #18498 |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jul 13, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-3.1 in PR #18499 |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jul 13, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #18500 |
ti-srebot
added a commit
that referenced
this pull request
Jul 13, 2020
ti-srebot
added a commit
that referenced
this pull request
Jul 13, 2020
ti-srebot
added a commit
that referenced
this pull request
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #18112
Problem Summary:
TiDB does not return the actual error when recovering a goroutine.
What is changed and how it works?
What's Changed:
How it Works:
As the title says.
Related changes
Check List
Tests
As the description in the related issue.
We'll get
ERROR 1105 (HY000): Out Of Memory Quota![conn_id=1]after this commit.Side effects
N/A
Release note