planner: don't put the handle column twice into the index column #18565
+22
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #18565 +/- ##
===========================================
Coverage ? 79.2622%
===========================================
Files ? 541
Lines ? 145300
Branches ? 0
===========================================
Hits ? 115168
Misses ? 20839
Partials ? 9293 |
ti-srebot
added
status/LGT2
ti-srebot
previously approved these changes
Jul 20, 2020
XuHuaiyu
added
status/LGT2
|
/rebuild |
XuHuaiyu
approved these changes
Jul 21, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jul 21, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-3.0 in PR #18710 |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jul 21, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-3.1 in PR #18711 |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jul 21, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #18712 |
winoros
added a commit
that referenced
this pull request
Jul 21, 2020
) (#18712) Co-authored-by: Yiding Cui <winoros@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #18564
Problem Summary:
The handle column appeared twice in the index column. Then the index join wrong think this index has one more column than it is.
What is changed and how it works?
What's Changed:
Removed the duplicate column.
Related changes
Check List
Tests
Release note