executor: return error from indexHashJoin worker to main thread #18573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuHuaiyu
requested review from
qw4990 and
lzmhhh123
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #18573 +/- ##
===========================================
Coverage 79.5119% 79.5119%
===========================================
Files 540 540
Lines 145758 145758
===========================================
Hits 115895 115895
Misses 20537 20537
Partials 9326 9326 |
ti-srebot
previously approved these changes
Jul 15, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@XuHuaiyu merge failed. |
|
/run-common-test |
|
/run-integration-copr-test |
|
/run-common-test |
|
/run-all-tests |
ti-srebot
approved these changes
Jul 15, 2020
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@XuHuaiyu merge failed. |
|
/run-integration-common-test |
|
/run-sqllogic-test-2 |
|
/run-unit-test |
XuHuaiyu
changed the title
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jul 15, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #18586 |
XuHuaiyu
pushed a commit
that referenced
this pull request
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #18572
Problem Summary:
Before this commit, the error happened during the outer/inner worker of indexHashJoin is not returned to the main thread.
What is changed and how it works?
What's Changed:
As the title says.
How it Works:
Related changes
v4.0.0
Check List
Tests
Side effects
N/A
Release note