Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grafana: add detailed memory usage for each instance #18679

Merged
merged 2 commits into from
Jul 20, 2020

Conversation

bobotu
Copy link
Contributor

@bobotu bobotu commented Jul 19, 2020

What problem does this PR solve?

We do not have a more detailed memory usage information. This PR adds dynamically generated panels for Go memory usage info in each instance.

图片

alloc-from-os

This is the resident memory usage of the process from the operating system's view.

estimate-insue

This is the estimated size of all live objects. At the bottom of the stack, You can see visually how the actual memory used changes。

estimate-garbage

This is the estimated size of garbages will be collected later. Stacked on top of estimate-insue, In the diagram, its top position is equivalent to heap_inuse.

reversed-by-go

This is the memory that can actually be returned to the operating system, but is temporarily reserved by Go Runtime.

used-by-go

This is the off-heap memory used by Go Runtime to maintain internal data structures.

gc-threshold

When heap_inuse will reach this limit, GC will be triggered. Each red dot on this line means GC has already finished at least once during the metrics scrape interval.

Release note

  • Add detailed memory usage for each instance in grafana.

@bobotu
Copy link
Contributor Author

bobotu commented Jul 19, 2020

/run-monitor-test

@sre-bot
Copy link
Contributor

sre-bot commented Jul 19, 2020

Visit the grafana server at: http://172.16.5.5:30112, it will last for 5 hours

@codecov
Copy link

codecov bot commented Jul 19, 2020

Codecov Report

Merging #18679 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #18679   +/-   ##
===========================================
  Coverage   79.2151%   79.2151%           
===========================================
  Files           542        542           
  Lines        146039     146039           
===========================================
  Hits         115685     115685           
  Misses        21018      21018           
  Partials       9336       9336           

@bobotu
Copy link
Contributor Author

bobotu commented Jul 20, 2020

PTAL @jackysp @lysu

@bobotu
Copy link
Contributor Author

bobotu commented Jul 20, 2020

/run-monitor-test

@sre-bot
Copy link
Contributor

sre-bot commented Jul 20, 2020

Visit the grafana server at: http://172.16.5.5:30752, it will last for 5 hours

Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 20, 2020
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jul 20, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 20, 2020
@jackysp
Copy link
Member

jackysp commented Jul 20, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 20, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@bobotu merge failed.

@bobotu
Copy link
Contributor Author

bobotu commented Jul 20, 2020

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@bobotu merge failed.

@bobotu bobotu merged commit 809df28 into pingcap:master Jul 20, 2020
@bobotu bobotu deleted the grafana-mem-details branch July 20, 2020 03:48
@bobotu
Copy link
Contributor Author

bobotu commented Jul 20, 2020

/run-cherry-picker

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 20, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #18683

ti-srebot added a commit that referenced this pull request Jul 29, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/metrics status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants