Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: support plan cache for cluster index (#18716) #18819

Merged
merged 2 commits into from
Sep 1, 2020
Merged

planner: support plan cache for cluster index (#18716) #18819

merged 2 commits into from
Sep 1, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #18716 to release-4.0

What problem does this PR solve?

Problem Summary: as title says.

What is changed and how it works?

How it Works: make rebuild ranges support cluster index

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Performance regression
    • Consumes more CPU

Release note

  • none

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Jul 28, 2020
Merged
@ti-srebot ti-srebot added this to the v4.0.4 milestone Jul 28, 2020
@imtbkcat imtbkcat modified the milestones: v4.0.4, v4.0.5 Jul 28, 2020
@imtbkcat imtbkcat modified the milestones: v4.0.5, v4.0.6 Aug 4, 2020
zz-jason
zz-jason reviewed Sep 1, 2020
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lzmhhh123 do we need this PR in release 4.0?

@lzmhhh123
Copy link
Contributor

@lzmhhh123 do we need this PR in release 4.0?

This PR fix some bugs about plan cache with point get. It’s different with the master branch PR.

@coocood
Copy link
Member

coocood commented Sep 1, 2020

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 1, 2020
zz-jason
zz-jason approved these changes Sep 1, 2020
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 1, 2020
@zz-jason
Copy link
Member

zz-jason commented Sep 1, 2020

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 19541
  • 19276
  • 18119
  • 19659
  • 18443

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 1, 2020
@zz-jason
Copy link
Member

zz-jason commented Sep 1, 2020

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 18443
  • 19452
  • 19276
  • 18119
  • 18443

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@zz-jason zz-jason merged commit adb3a4a into pingcap:release-4.0 Sep 1, 2020
@ichn-hu ichn-hu mentioned this pull request Sep 2, 2020
Merged
@ichn-hu ichn-hu mentioned this pull request Sep 2, 2020
Merged
SunRunAway pushed a commit that referenced this pull request Sep 4, 2020
@ichn-hu
executor: revert test case introduced in #18819 to solve the data rac…
22de543 
…e on release-4.0 (#19722)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason approved these changes

@coocood coocood Awaiting requested review from coocood

@eurekaka eurekaka Awaiting requested review from eurekaka

@qw4990 qw4990 Awaiting requested review from qw4990

@winoros winoros Awaiting requested review from winoros

Assignees

@lzmhhh123 lzmhhh123

Labels
component/executor sig/execution SIG execution sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/4.0-cherry-pick
Projects
None yet
Milestone
v4.0.6
Development

Successfully merging this pull request may close these issues.
6 participants
@ti-srebot @lzmhhh123 @coocood @zz-jason @AndreMouche @imtbkcat