ddl: add addingDefinition field for adding partition replica check (#18495)
#18865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
ti-srebot
added
compatibility-breaker
ti-srebot
requested review from
crazycs520,
djshow832,
tangenta,
tiancaiamao and
zimulala
zimulala
reviewed
Jul 31, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
djshow832
reviewed
Aug 3, 2020
AilinKid
added
the
priority/release-blocker
AilinKid
force-pushed
the
release-4.0-c7c98d738068
branch
from
c100f25
to
d7f93a3
Compare
Signed-off-by: AilinKid <314806019@qq.com>
AilinKid
force-pushed
the
release-4.0-c7c98d738068
branch
from
91042a8
to
4318b8e
Compare
|
/run-all-tests |
AilinKid
force-pushed
the
release-4.0-c7c98d738068
branch
from
aa4acef
to
99f52ba
Compare
|
/run-all-tests |
ti-srebot
added
status/LGT2
|
/run-unit-test |
|
/run-check_dev |
|
/run-unit-test |
|
/run-unit-test |
AilinKid
force-pushed
the
release-4.0-c7c98d738068
branch
from
4d4ff12
to
fa9cae5
Compare
|
/run-all-tests |
|
/run-all-tests |
|
/run-unit-test |
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
/merge |
|
Sorry @imtbkcat, you don't have permission to trigger auto merge event on this branch. |
bb7133
approved these changes
Aug 3, 2020
ti-srebot
added
status/LGT3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #18495 to release-4.0
Signed-off-by: AilinKid 314806019@qq.com
What problem does this PR solve?
Issue Number: close #18496
Problem Summary:
It is reported that if a table is in tiflash replica mode and it's available state is
true, the new added partition will cause query block because the new added partition hasn't been replicated completely.That's why we wanna add a mid state for adding partiton. In the delete-only state, the
DDLowner will check for the new added partition's replica info. Once it is completed, then make it public.What is changed and how it works?
What's Changed:
1: add a mid state (delete only for add partiton)
2: add the rollback logic for add partition
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note