-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gc_worker: reduce GC scan locks when meeting region cache miss (#18385) #18875
gc_worker: reduce GC scan locks when meeting region cache miss (#18385) #18875
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
/run-all-tests |
@coocood, @jackysp, @MyonKeminta, @youjiali1995, PTAL. |
Please fix conflicts |
@coocood, @jackysp, @MyonKeminta, @youjiali1995, PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PTAL @MyonKeminta |
@jackysp, @MyonKeminta, @coocood, @youjiali1995, PTAL. |
/merge |
/run-all-tests |
@ti-srebot merge failed. |
@jackysp, @MyonKeminta, @coocood, @youjiali1995, PTAL. |
/merge |
/run-all-tests |
cherry-pick #18385 to release-3.1
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
currently, gc worker will rescan locks when meet region cache miss error which makes slow scan job become more slow.
What is changed and how it works?
What's Changed, How it Works:
when region cache miss error(current is a fake epochNotMatch), it just indicates "maybe region has changed and we need to reload region from PD", we can continue resolve scan lock result if all lock still in that region.
this can help situations like:
but it didn't help the situation that:
maybe we can improve it later(to avoid complex modification)
Related changes
Check List
Tests
Side effects
Release note
This change is