ddl: check allocator's existence before allocate/rebase #18932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #18932 +/- ##
===========================================
Coverage 79.4424% 79.4424%
===========================================
Files 547 547
Lines 149551 149551
===========================================
Hits 118807 118807
Misses 21252 21252
Partials 9492 9492 |
djshow832
reviewed
Aug 4, 2020
| } | ||
| } else { | ||
| if err = tb.RebaseAutoID(nil, tbInfo.AutoRandID-1, false, tp); err != nil { | ||
| if alloc := allocs.Get(tp); alloc != nil { |
There was a problem hiding this comment.
So the manual rebase will be just ignored when alloc==nil?
There was a problem hiding this comment.
Yes. This is consistent with MySQL.
djshow832
reviewed
Aug 4, 2020
crazycs520
reviewed
Aug 4, 2020
ti-srebot
approved these changes
Aug 4, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
tangenta
added a commit
to ti-srebot/tidb
that referenced
this pull request
May 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #18931
Problem Summary:
After #18326,
rowidallocator is not necessarily existed in every table. Before allocate/rebase values, a nil check for allocators is missed.What is changed and how it works?
What's Changed and how it works: add a nil check for allocators before using them.
Related changes
Check List
Tests
Side effects: N/A
Release note