Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grafana: add TiDB-Runtime dashboard #19144

Merged
merged 5 commits into from
Aug 24, 2020
Merged

grafana: add TiDB-Runtime dashboard #19144

merged 5 commits into from
Aug 24, 2020

Conversation

bobotu
Copy link
Contributor

@bobotu bobotu commented Aug 12, 2020 •
edited
Loading

What problem does this PR solve?

Add a new dashboard to show runtime related metrics.

Release note

  • Add `TiDB-Runtime` dashboard.

@bobotu bobotu requested review from lysu and jackysp August 12, 2020 04:16
@codecov
Copy link

codecov bot commented Aug 12, 2020 •
edited
Loading

Codecov Report

Merging #19144 into master will decrease coverage by 0.0579%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             master     #19144        +/-   ##
================================================
- Coverage   79.1417%   79.0838%   -0.0580%     
================================================
  Files           550        549         -1     
  Lines        149749     149210       -539     
================================================
- Hits         118514     118001       -513     
+ Misses        21689      21682         -7     
+ Partials       9546       9527        -19

jackysp
jackysp reviewed Aug 12, 2020
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do any others need to use irate?
Go GC STW Duration?
All durations should use irate?
Maybe we could separate several PRs to update them.

@bobotu
Copy link
Contributor Author

bobotu commented Aug 12, 2020 •
edited
Loading

Do any others need to use irate?
Go GC STW Duration?
All durations should use irate?

I'm investigating them. I also find the Resolution should be adjusted in this scenario.

Maybe we could separate several PRs to update them.

I think it is better to update them in this PR. I'm going to mark this PR as a draft and will reopen it later.

@jackysp

@bobotu bobotu marked this pull request as draft August 12, 2020 05:34
@bobotu bobotu changed the title grafana: use irate instead of rate for CPU usage grafana: add TiDB-Runtime dashboard Aug 13, 2020
@pingcap pingcap deleted a comment from sre-bot Aug 13, 2020
@bobotu
Copy link
Contributor Author

bobotu commented Aug 14, 2020

/run-monitor-test

@pingcap pingcap deleted a comment from sre-bot Aug 14, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Aug 14, 2020

Visit the grafana server at: http://172.16.5.5:30996, it will last for 5 hours

@bobotu bobotu marked this pull request as ready for review August 14, 2020 09:33
@bobotu
Copy link
Contributor Author

bobotu commented Aug 14, 2020

PTAL @jackysp @lysu

@bobotu bobotu marked this pull request as draft August 14, 2020 13:29
@bobotu
Copy link
Contributor Author

bobotu commented Aug 14, 2020

Still need some modifications

@bobotu bobotu marked this pull request as ready for review August 17, 2020 03:00
@bobotu
Copy link
Contributor Author

bobotu commented Aug 17, 2020

/run-monitor-test

@sre-bot
Copy link
Contributor

sre-bot commented Aug 17, 2020

Visit the grafana server at: http://172.16.5.5:31643, it will last for 5 hours

@bobotu
Copy link
Contributor Author

bobotu commented Aug 17, 2020

/run-monitor-test

@sre-bot
Copy link
Contributor

sre-bot commented Aug 17, 2020

Visit the grafana server at: http://172.16.5.5:31333, it will last for 5 hours

@jackysp
Copy link
Member

jackysp commented Aug 17, 2020 •
edited
Loading

image
I think you forget to set auto-refresh for the new dashboard.

@bobotu
Copy link
Contributor Author

bobotu commented Aug 18, 2020

/run-monitor-test

@sre-bot
Copy link
Contributor

sre-bot commented Aug 18, 2020

Visit the grafana server at: http://172.16.5.5:30625, it will last for 5 hours

@bobotu
Copy link
Contributor Author

bobotu commented Aug 18, 2020

/run-monitor-test

@sre-bot
Copy link
Contributor

sre-bot commented Aug 18, 2020

Visit the grafana server at: http://172.16.5.5:32704, it will last for 5 hours

jackysp
jackysp reviewed Aug 21, 2020
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 21, 2020
lysu
lysu reviewed Aug 24, 2020
View reviewed changes
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Aug 24, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Aug 24, 2020
@lysu
Copy link
Contributor

lysu commented Aug 24, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 24, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@bobotu merge failed.

@bobotu
Copy link
Contributor Author

bobotu commented Aug 24, 2020

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit d152b51 into pingcap:master Aug 24, 2020
@ti-srebot ti-srebot mentioned this pull request Aug 24, 2020
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #19396

@bobotu bobotu deleted the irate-cpu branch August 26, 2020 05:42
bobotu pushed a commit to ti-srebot/tidb that referenced this pull request Sep 2, 2020
@ti-srebot
grafana: add TiDB-Runtime dashboard (pingcap#19144)
c76b923 
* grafana: add `TiDB-Runtime` dashboard

* address comments

* add live objects & refine title of gc count panel

* show instance selector

Co-authored-by: ti-srebot <66930949+ti-srebot@users.noreply.github.com>
zz-jason pushed a commit that referenced this pull request Sep 3, 2020
@ti-srebot
grafana: add TiDB-Runtime dashboard (#19144) (#19396)
3d6935d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp left review comments

@lysu lysu lysu left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

Assignees
No one assigned
Labels
component/metrics status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bobotu @sre-bot @jackysp @lysu @ti-srebot