Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix panic on selectResultRuntimeStats.String #19277

Merged
merged 1 commit into from
Aug 19, 2020
Merged

fix panic on selectResultRuntimeStats.String #19277

merged 1 commit into from
Aug 19, 2020

Conversation

crazycs520
Copy link
Contributor

Signed-off-by: crazycs520 crazycs520@gmail.com

What problem does this PR solve?

fix #19275

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

  • Performance regression
    • Consumes more CPU

Release note

  • No

@crazycs520
fix panic on selectResultRuntimeStats.String
bee070a 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520 crazycs520 added type/bugfix This PR fixes a bug. component/test labels Aug 19, 2020
@crazycs520 crazycs520 requested a review from a team as a code owner August 19, 2020 03:17
@crazycs520 crazycs520 requested review from fzhedu and removed request for a team August 19, 2020 03:17
@crazycs520
Copy link
Contributor Author

@lysu. @qw4990 PTAL

qw4990
qw4990 reviewed Aug 19, 2020
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 19, 2020
@crazycs520
Copy link
Contributor Author

/run-all-tests

@amyangfei amyangfei mentioned this pull request Aug 19, 2020
Closed
@tiancaiamao
Copy link
Contributor

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Aug 19, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Aug 19, 2020
@tiancaiamao tiancaiamao merged commit fcfe99a into pingcap:master Aug 19, 2020
crazycs520 added a commit to ti-srebot/tidb that referenced this pull request Sep 3, 2020
@crazycs520
distsql: fix panic on selectResultRuntimeStats.String (pingcap#19277)
8135141
@ti-srebot ti-srebot mentioned this pull request Sep 3, 2020
Merged
@crazycs520
Copy link
Contributor Author

No need cherry-pick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@fzhedu fzhedu Awaiting requested review from fzhedu

Assignees
No one assigned
Labels
component/test status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic on selectResultRuntimeStats.String()
4 participants
@crazycs520 @tiancaiamao @qw4990 @ti-srebot