-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: bug fix for vectorized casting real as ... (#19485) #19594
expression: bug fix for vectorized casting real as ... (#19485) #19594
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
need merge with tikv/tikv#8562 to keep CI can pass |
/run-integration-copr-test tikv=pr/8562 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It should merge with tikv/tikv#8562 together. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@zz-jason tikv/tikv#8562 has all-test-pass please help merge if free (no privilege - -) |
cherry-pick #19485 to release-4.0
What problem does this PR solve?
Issue Number: close #17809
Problem Summary:
Casting from column value
0.0
of real type to datetime type produces wrong resultNULL
.But casting from constant produces the expected result
0000-00-00 00:00:00
.What is changed and how it works?
What's Changed:
builtinCasrRealAsTimeSig.vecEvalTime
will treat real value0.0
as a special case, and assignZeroTime
to the result.How it Works:
evalTime
has this special case butvecEvalTime
does not.vecEvalTime
Related changes
Check List
Tests
Release note