Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expressions: Support push ROUND function to TiFlash #19616

Merged
merged 4 commits into from
Sep 11, 2020
Merged

expressions: Support push ROUND function to TiFlash #19616

merged 4 commits into from
Sep 11, 2020

Conversation

leiysky
Copy link
Contributor

@leiysky leiysky commented Aug 31, 2020 •
edited
Loading

Signed-off-by: leiysky leiysky@outlook.com

What problem does this PR solve?

Problem Summary:
Support ROUND function push to TiFlash.

What is changed and how it works?

What's Changed:

  • Enable the switcher to push ROUND to TiFlash

How it Works:

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Integration test (sqllogic)

Release note

  • Support push ROUND function to TiFlash

@leiysky
support round function push down to TiFlash
776857b 
Signed-off-by: leiysky <leiysky@outlook.com>
@leiysky leiysky requested a review from a team as a code owner August 31, 2020 08:04
@leiysky leiysky requested review from SunRunAway and removed request for a team August 31, 2020 08:04
@tangenta
Copy link
Contributor

/run-all-tests

2 similar comments
@leiysky
Copy link
Contributor Author

leiysky commented Sep 1, 2020

/run-all-tests

@leiysky
Copy link
Contributor Author

leiysky commented Sep 2, 2020

/run-all-tests

SunRunAway
SunRunAway reviewed Sep 8, 2020
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 8, 2020
tangenta
tangenta reviewed Sep 11, 2020
View reviewed changes
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Sep 11, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 11, 2020
@leiysky
Copy link
Contributor Author

leiysky commented Sep 11, 2020

@tangenta Please merge this.

@tangenta tangenta merged commit ab00d56 into pingcap:master Sep 11, 2020
@leiysky leiysky deleted the feature/support-round-pushdown-tiflash branch September 11, 2020 05:53
leiysky added a commit to leiysky/tidb that referenced this pull request Sep 11, 2020
@leiysky
support round function push down to TiFlash (pingcap#19616)
8f87805
@ti-srebot ti-srebot mentioned this pull request Sep 14, 2020
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #19967

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 14, 2020
@leiysky @ti-srebot
cherry pick pingcap#19616 to release-4.0
c1acfd9 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
SunRunAway pushed a commit that referenced this pull request Sep 21, 2020
@ti-srebot
cherry pick #19616 to release-4.0 (#19967)
d56980b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta left review comments

@SunRunAway SunRunAway SunRunAway left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

Assignees
No one assigned
Labels
component/expression status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leiysky @tangenta @ti-srebot @SunRunAway