Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix the issue that SELECT ... INTO OUTFILE returns runtime error (#19438) #19672

Merged
merged 4 commits into from
Sep 3, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #19438 to release-4.0


What problem does this PR solve?

Issue Number: close #19314

Problem Summary: SELECT ... INTO OUTFILE returns runtime error

What is changed and how it works?

Handle bit type correctly when dumping rows into files.

Check List

Tests

  • Unit test

Release note

  • executor: fix the issue that SELECT ... INTO OUTFILE returns runtim…

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@XuHuaiyu
Copy link
Contributor

XuHuaiyu commented Sep 2, 2020

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 2, 2020
@zz-jason
Copy link
Member

zz-jason commented Sep 2, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 2, 2020
@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 19269
  • 19684
  • 19264
  • 19682
  • 17924
  • 19664
  • 18327
  • 18164
  • 18115

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 2, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@zz-jason
Copy link
Member

zz-jason commented Sep 2, 2020

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 17924
  • 18115
  • 18164
  • 18327
  • 19264
  • 19664

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@qw4990
Copy link
Contributor

qw4990 commented Sep 2, 2020

/run-all-tests

@qw4990
Copy link
Contributor

qw4990 commented Sep 3, 2020

/run-all-tests

@winoros
Copy link
Member

winoros commented Sep 3, 2020

The race test failed in the unit-test is investigating by @tiancaiamao
Master branch has fixed by refactoring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants