expression: fallback vectorized control expressions (#19367) #19749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
/run-all-tests |
ti-srebot
added
component/expression
type/4.0-cherry-pick
type/bugfix
|
/run-all-tests |
ti-srebot
added
status/LGT2
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@ti-srebot merge failed. |
SunRunAway
approved these changes
Sep 4, 2020
|
/run-tics-test |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #19367 to release-4.0
What problem does this PR solve?
Issue Number: close #17725
Problem Summary: the vectorized execution runs each branch, some of them cause unnecessary errors. In fact, the later computation depends on the results of formers, the vectorization of laters should consider the formers. This needs to change the interface of vectorization of expressions.
We add fallback mechnism to avoid unnecessary warnings or errors. If errors/warnings occur for unsure branches, we fallback the vectorization to scalar execution.
In addition, the constant folding case is in #19675.
What is changed and how it works?
Proposal: xxx
What's Changed: disable vectroization in the source file of control expressions.
How it Works:
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Release note