types: fix ambiguous year conversion #19781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SunRunAway
reviewed
Sep 4, 2020
|
LGTM |
ti-srebot
added
status/LGT2
ti-srebot
previously approved these changes
Sep 11, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@xhebox merge failed. |
|
@ti-srebot /run-sqllogic-test-2 |
|
/run-sqllogic-test-2 |
|
/merge |
|
/run-all-tests |
|
/run-integration-ddl-test |
|
@xhebox merge failed. |
|
/run-all-tests |
|
@ti-srebot /run-common-test |
|
/run-common-test |
|
@ti-srebot /run-common-test |
|
/run-common-test |
|
@ti-srebot /run-all-tests |
|
/run-all-tests |
2 similar comments
|
/run-all-tests |
|
/run-all-tests |
|
@ti-srebot /run-integration-common-test |
|
/run-integration-common-test |
qw4990
approved these changes
Sep 14, 2020
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Sep 29, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #20292 |
zz-jason
pushed a commit
that referenced
this pull request
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary: In the seek of #13094, I found some other bugs related to year type conversion. After some digging with mariadb(8.xx), I found the condition of string to "0" or "2000". And I add more tests tested under mariadb. Type is kinda fundamental. I think it is better to back port the patch.
For the reference, 5.7 of ambiguous year conversion documentation here.
Related changes
Check List
Tests
Release note