planner,executor: support global index for IndexScan and IndexLookUpReader #19821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-check-title |
|
Please follow PR Title Format:
|
tiancaiamao
changed the title
|
go mod edit -replace github.com/pingcap/parser= github.com/ldeng-ustc/parser@global_index_executor |
|
PTAL @qw4990 @lzmhhh123 |
|
LGTM |
|
PTAL @lzmhhh123 |
ti-srebot
added
status/LGT2
ti-srebot
approved these changes
Sep 24, 2020
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@ldeng-ustc merge failed. |
|
/merge |
|
/run-all-tests |
|
@ldeng-ustc merge failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Support global index in IndexScan and IndexLookUpReader
Proposal: #18982
This PR is based on parser #1010.
Related PR: tikv #8603.
What is changed and how it works?
How it Works:
IndexScan for global index is just like IndexScan for non-parition table index, so we just skip
buildPartitionTablewhen index is global.For supporting double read, add an extra paritionID column when first read. In parition tables, locate a row not only need a handle, but also a partitionID, so we add
PartitionHandle, which combine a paritionID and a normal handle. Then, usePartitionHanleto correctly sort and setKvRangesin tableReader. Because meta data of all paritions of a parition table is same, so we can use a single tableReader to read all rows in different partitions we need.Check List
Tests
Release note