Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: add concurrency limit on union executor (#19827) #19886

Merged
merged 4 commits into from
Sep 9, 2020
Merged

executor: add concurrency limit on union executor (#19827) #19886

merged 4 commits into from
Sep 9, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #19827 to release-4.0

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

  1. Use system variable tidb_executor_concurrency to control the concurrency on union executor.
  2. Create n worker to pull result from executors.
  3. Close children executors that has been opened.

How it Works:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch 4.0

Check List

Tests

  • Unit test

Side effects

  • Performance regression

Release note

  • Support adjust the concurrency on union executor.

@wshwsh12 @ti-srebot
cherry pick pingcap#19827 to release-4.0
8054dd4 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Sep 8, 2020
Merged
@ti-srebot ti-srebot added priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/execution SIG execution type/4.0-cherry-pick labels Sep 8, 2020
@ti-srebot ti-srebot added this to the v4.0.6 milestone Sep 8, 2020
XuHuaiyu
XuHuaiyu reviewed Sep 9, 2020
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The doc needs to be updated

@AilinKid
Copy link
Contributor

AilinKid commented Sep 9, 2020

/run-unit-test

@wshwsh12
Copy link
Contributor

wshwsh12 commented Sep 9, 2020

/run-all-tests

AilinKid
AilinKid reviewed Sep 9, 2020
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 9, 2020
@wshwsh12
Copy link
Contributor

wshwsh12 commented Sep 9, 2020

/run-sqllogic-test-1

lysu
lysu reviewed Sep 9, 2020
View reviewed changes
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 9, 2020
@SunRunAway SunRunAway merged commit be055a3 into pingcap:release-4.0 Sep 9, 2020
glkappe added a commit to glkappe/docs-cn that referenced this pull request Dec 7, 2020
@glkappe
tidb_distsql_scan_concurrency Add change description
5517fad 
tidb_distsql_scan_concurrency Add change description 
 pingcap/tidb#19886
@glkappe glkappe mentioned this pull request Dec 7, 2020
Merged
10 tasks
TomShawn added a commit to pingcap/docs-cn that referenced this pull request Dec 14, 2020
@glkappe @TomShawn
Add description for tidb_distsql_scan_concurrency (#5035)
c5e8aad 
* tidb_distsql_scan_concurrency Add change description

tidb_distsql_scan_concurrency Add change description 
 pingcap/tidb#19886

* Update system-variables

ok

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

* Update system-variables.md

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@ti-srebot ti-srebot mentioned this pull request Dec 14, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu left review comments

@lysu lysu lysu left review comments

@AilinKid AilinKid AilinKid approved these changes

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

Assignees

@wshwsh12 wshwsh12

Labels
priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2. type/4.0-cherry-pick
Projects
None yet
Milestone
v4.0.6
Development

Successfully merging this pull request may close these issues.
6 participants
@ti-srebot @AilinKid @wshwsh12 @lysu @XuHuaiyu @SunRunAway