expression, types: Function DAY/DAYOFMONTH the NoZeroDateMode sql mode check when string cast to time #19930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please follow PR Title Format:
Or if the count of mainly changed packages are more than 3, use
|
Patrick0308
changed the title
Patrick0308
changed the title
Patrick0308
changed the title
qw4990
reviewed
Sep 11, 2020
There was a problem hiding this comment.
Please add cases in #11178 as a unit test into TiDB. @Patrick0308
|
@qw4990 OK |
Patrick0308
changed the title
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
|
/run-all-tests |
Comment on lines
+1260
to
+1262
| if res.IsZero() && b.ctx.GetSessionVars().SQLMode.HasNoZeroDateMode() { | ||
| return types.ZeroDate, true, handleInvalidTimeError(b.ctx, types.ErrWrongValue.GenWithStackByArgs(types.DateTimeStr, res.String())) | ||
| } |
There was a problem hiding this comment.
Please add a test case to cover this.
|
I'm going to close this PR since it hasn't been updated for a long time. feel free to reopen if you want to continue with it. thank you for your contribution. BTW, seems the original issue has been fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: a part of #11178
Problem Summary:
What is changed and how it works?
What's Changed: check the NoZeroDateMode sql mode check when string cast to time .
How it Works:
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Release note