*: fix cop task runtime information is wrong in the concurrent executor (#19849) #19947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
/run-all-tests |
ti-srebot
added
component/executor
sig/execution
ti-srebot
requested review from
AilinKid,
tangenta,
wjhuang2016 and
XuHuaiyu
This reverts commit 865b2f7.
…lease-4.0-bada2801ac1f
|
@AilinKid, Thanks for your review, however we are sorry that your vote won't be count. |
|
@crazycs520 seems the cherry-pick is incorrect: |
|
wait #20199 merge first. |
|
Wait #20430 merge first. |
…or (pingcap#19849) Signed-off-by: crazycs520 <crazycs520@gmail.com>
…lease-4.0-bada2801ac1f
|
/run-all-tests |
|
/run-unit-test |
ti-srebot
added
status/LGT2
crazycs520
approved these changes
Oct 19, 2020
ti-srebot
added
status/LGT3
|
/merge |
|
Sorry @crazycs520, this branch cannot be merged without an approval of release maintainers |
|
@SunRunAway, Could you help to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #19849 to release-4.0
What problem does this PR solve?
close #19847
What is changed and how it works?
In some case such as
index join, 1 plan maybe use multipleexecutorfor concurrency, so, 1 plan ID maybe have multiple executor runtime stats.This PR use an array to record executor runtime stats and merge them when query the executor runtime stats.
Related changes
Check List
Tests
Side effects
Release note