Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: support new aggregate function APPROX_PERCENTILE (#19799) #20197

Merged
merged 6 commits into from
Oct 19, 2020
Merged

executor: support new aggregate function APPROX_PERCENTILE (#19799) #20197

merged 6 commits into from
Oct 19, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #19799 to release-4.0

What problem does this PR solve?

Issue Number: #19405

Problem Summary:

What is changed and how it works?

What's Changed:

  • Add a new aggregate function APPROX_PERCENTILE

How it Works:

  • Fetch a column, and perform k-th smallest element algorithm on it to find specified percentile.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn: TODO
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Side effects

Release note

  • Support new aggregate function APPROX_PERCENTILE

@leiysky @ti-srebot
cherry pick pingcap#19799 to release-4.0
840495f 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Sep 24, 2020
Merged
@ti-srebot ti-srebot added this to the v4.0.7 milestone Sep 24, 2020
lzmhhh123
lzmhhh123 reviewed Sep 24, 2020
View reviewed changes
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leiysky Please help resolve conflicts.

@lzmhhh123 lzmhhh123 modified the milestones: v4.0.7, v4.0.8 Sep 24, 2020
@leiysky
Copy link
Contributor

leiysky commented Sep 24, 2020

/run-all-tests

1 similar comment
@leiysky
Copy link
Contributor

leiysky commented Sep 25, 2020

/run-all-tests

@leiysky
Copy link
Contributor

leiysky commented Oct 19, 2020

/run-all-tests

lzmhhh123
lzmhhh123 reviewed Oct 19, 2020
View reviewed changes
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 19, 2020
@leiysky
Copy link
Contributor

leiysky commented Oct 19, 2020

/merge

@ti-srebot
Copy link
Contributor Author

Sorry @leiysky, this branch cannot be merged without an approval of release maintainers

@lzmhhh123
Copy link
Contributor

/cc @SunRunAway

fzhedu
fzhedu approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@fzhedu fzhedu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 19, 2020
@lzmhhh123
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor Author

Sorry @lzmhhh123, this branch cannot be merged without an approval of release maintainers

@lzmhhh123
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor Author

Sorry @lzmhhh123, this branch cannot be merged without an approval of release maintainers

@ghost ghost changed the title executor: support new aggregate funtion APPROX_PERCENTILE (#19799) executor: support new aggregate function APPROX_PERCENTILE (#19799) Oct 19, 2020
@ti-srebot ti-srebot added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Oct 19, 2020
@leiysky
Copy link
Contributor

leiysky commented Oct 19, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 19, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit cae843b into pingcap:release-4.0 Oct 19, 2020
@leiysky leiysky deleted the release-4.0-aceecf073276 branch October 19, 2020 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzmhhh123 lzmhhh123 lzmhhh123 approved these changes

@fzhedu fzhedu fzhedu approved these changes

@SunRunAway SunRunAway SunRunAway approved these changes

Assignees

@leiysky leiysky

Labels
challenge-program component/expression sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT3 The PR has already had 3 LGTM. type/new-feature type/4.0-cherry-pick
Projects
None yet
Milestone
v4.0.8
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-srebot @leiysky @lzmhhh123 @SunRunAway @fzhedu