Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix sort result for batch-point-get by unsigned pk (#20108) #20205

Merged
merged 6 commits into from
Oct 3, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #20108 to release-4.0


What problem does this PR solve?

Issue Number: close #20100

Problem Summary:

batch point sort handle before batch-get but didn't take care handle maybe uint

What is changed and how it works?

What's Changed, How it Works:

sort as uint when it's unsigned pk

Related changes

  • Need to cherry-pick to the release branch 4.0

Check List

Tests

  • Unit test

Side effects

  • n/a

Release note

  • fix sort result for max unsigned int in batch-point-get

This change is Reviewable

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@lysu
Copy link
Contributor

lysu commented Sep 25, 2020

/run-all-tests

@lysu
Copy link
Contributor

lysu commented Sep 25, 2020

/run-check_dev

@ti-srebot
Copy link
Contributor Author

@coocood, @qw4990, @lzmhhh123, PTAL.

@coocood
Copy link
Member

coocood commented Sep 27, 2020

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 27, 2020
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 27, 2020
@ti-srebot
Copy link
Contributor Author

@lzmhhh123, @coocood, @qw4990, PTAL.

1 similar comment
@ti-srebot
Copy link
Contributor Author

@lzmhhh123, @coocood, @qw4990, PTAL.

@zz-jason
Copy link
Member

zz-jason commented Oct 3, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 3, 2020
@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 20297
  • 20293
  • 20155
  • 20074
  • 20252
  • 20240
  • 20248
  • 20249
  • 20216
  • 20154
  • 19944
  • 20210

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@zz-jason
Copy link
Member

zz-jason commented Oct 3, 2020

/run-sqllogic-test
/run-unit-test

@zz-jason
Copy link
Member

zz-jason commented Oct 3, 2020

/run-sqllogic-test

@zz-jason
Copy link
Member

zz-jason commented Oct 3, 2020

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 20240
  • 20248
  • 20210
  • 20146

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit 7eab75c into pingcap:release-4.0 Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants