Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix analyze update panic cause by duplicate call analyze executor Close method #20390

Merged
merged 11 commits into from
Oct 12, 2020

Conversation

crazycs520
Copy link
Contributor

What problem does this PR solve?

Close #20389

related PR: #19106

What is changed and how it works?

Related changes

  • No.

Check List

Tests

  • Unit test

Side effects

  • No

Release note

  • No

…ecutor Close method

Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520 crazycs520 added the type/bugfix This PR fixes a bug. label Oct 10, 2020
@crazycs520 crazycs520 requested a review from a team as a code owner October 10, 2020 09:34
@crazycs520 crazycs520 requested review from lzmhhh123 and removed request for a team October 10, 2020 09:34
@sre-bot
Copy link
Contributor

sre-bot commented Oct 10, 2020

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what's changed

Or if the count of mainly changed packages are more than 3, use

  • *: what's changed

@crazycs520
Copy link
Contributor Author

@SunRunAway PTAL

@crazycs520 crazycs520 changed the title Fix analyze update executor: fix analyze update panic cause by duplicate call analyze executor Close method Oct 10, 2020
@crazycs520
Copy link
Contributor Author

/run-all-tests

@github-actions github-actions bot added the sig/execution SIG execution label Oct 10, 2020
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520
Copy link
Contributor Author

/run-all-tests

This reverts commit 231bf47.
@crazycs520
Copy link
Contributor Author

/run-all-tests

@tiancaiamao
Copy link
Contributor

/run-unit-test

Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520
Copy link
Contributor Author

/run-all-tests

Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520
Copy link
Contributor Author

/run-all-tests

Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520
Copy link
Contributor Author

/run-all-tests

@crazycs520
Copy link
Contributor Author

/run-mybatis-test
/run-sqllogic-test-1
/run-sqllogic-test-2

Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiancaiamao
Copy link
Contributor

/run-all-tests

@tiancaiamao
Copy link
Contributor

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 12, 2020
@crazycs520 crazycs520 added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 12, 2020
@crazycs520
Copy link
Contributor Author

/run-all-tests

@tiancaiamao tiancaiamao merged commit 875cf6d into pingcap:master Oct 12, 2020
@crazycs520 crazycs520 deleted the fix-analyze-update branch October 12, 2020 12:26
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Nov 16, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #21067

crazycs520 added a commit to ti-srebot/tidb that referenced this pull request Nov 16, 2020
crazycs520 added a commit to ti-srebot/tidb that referenced this pull request Nov 16, 2020
ti-srebot added a commit that referenced this pull request Nov 19, 2020
…ecutor Close method (#20390) (#21067)

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic when explain analyze update statement
5 participants