sessionctx,store,kv: add a session variable to export last txn info (#19949) #20696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
/run-all-tests |
ti-srebot
requested review from
cfzjywxk,
coocood,
jackysp,
MyonKeminta,
sticnarf,
SunRunAway and
youjiali1995
|
@zyguan please accept the invitation then you can push to the cherry-pick pull requests. |
Signed-off-by: zyguan <zhongyangguan@gmail.com>
|
LGTM |
|
@MyonKeminta, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: execution(slack). |
|
@youjiali1995, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: execution(slack). |
ti-srebot
added
status/LGT2
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #19949 to release-4.0
Signed-off-by: zyguan zhongyangguan@gmail.com
What problem does this PR solve?
Problem Summary: Currently we can get start ts from
@@tidb_current_tswithin a transaction, however there is no way to get commit ts. The testability can be improved a lot if we can access the commit ts (and may more info) of the last committed transaction.What is changed and how it works?
What's Changed: Add a session variable,
@@tidb_last_txn_info, which export timestamps of the last committed transaction.How it Works: A new txn option
CommitHook, which indicates a callback function with signature offunc(TxnInfo, error), is added and will be called right after a transaction gets committed. In this callback function, we attach txn info toSessionVarsand export ts fields as session variables.Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note